Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing user-config options #8429

Merged
merged 5 commits into from Jan 25, 2023

Conversation

Bad3r
Copy link
Collaborator

@Bad3r Bad3r commented Jan 25, 2023

  • add :arweave/gateway configuration option
  • add :custom-js-url configuration option
  • add :feature/enable-whiteboards? configuration option
  • add :journal/page-title-format configuration option

I followed the order and wording style of the current configuration options as good as I could.

@Bad3r Bad3r added the user-config User configuration e.g. ~/.logseq/config or logseq/*.edn label Jan 25, 2023
@Bad3r Bad3r requested review from hdansou and cnrpman January 25, 2023 03:21
@Bad3r Bad3r self-assigned this Jan 25, 2023
Copy link
Collaborator

@logseq-cldwalker logseq-cldwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Bad3r Thanks for documenting these! 👍 🚢

@@ -43,8 +47,18 @@
;; Enable flashcards
;; :feature/enable-flashcards? true

;; Disable Built-in Scheduled and deadline Query
;; Enable Whiteboards
;; :feature/enable-whiteboards?
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to add a value here but I can fix

@logseq-cldwalker logseq-cldwalker merged commit cdddabf into master Jan 25, 2023
@logseq-cldwalker logseq-cldwalker deleted the fix/missing-user-config-options branch January 25, 2023 21:56
logseq-cldwalker added a commit that referenced this pull request Jan 25, 2023
@Bad3r Bad3r modified the milestone: 0.8.17 Jan 25, 2023
sallto pushed a commit to sallto/logseq that referenced this pull request Jan 31, 2023
* fix: add scheduled/future-days configuration option 🔨

* fix: add :journal/page-title-format configuration option 🔨

* fix: add :feature/enable-whiteboards? configuration option 🔨

* fix: add :custom-js-url configuration option 🔨

* fix: add :arweave/gateway configuration option 🔨
sallto pushed a commit to sallto/logseq that referenced this pull request Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:type/bug-fix user-config User configuration e.g. ~/.logseq/config or logseq/*.edn
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants